Skip to content

Fix accessibility for table block #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletions src/js/classes/TableBlock.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
import AbstractDomElement from './AbstractDomElement'
import each from '../utils/each'

// ----
// class
// ----
class TableBlock extends AbstractDomElement {
constructor(element, options) {
const instance = super(element, options)

// avoid double init :
if (!instance.isNewInstance()) {
return instance
}

const el = this._element
const table = el.querySelector('table')
const thead = table.querySelector('thead')
const legend = el.querySelector('figcaption')

// Tableau de données
if (thead) {
const ths = thead.querySelectorAll('th')

each(ths, function (th) {
th.setAttribute('scope', 'col')
})

// Fix de la légende / titre du tableau. figcaption n'est pas supporté : https://accessibilite.numerique.gouv.fr/methode/glossaire/#tableau-de-donnees-ayant-un-titre
if (legend) {
const caption = document.createElement('caption')
caption.className = legend.className
caption.innerHTML = legend.innerHTML
table.insertBefore(caption, table.firstChild)
legend.remove()
}
}

// Tableau de mise en forme
if (!thead) {
table.setAttribute('role', 'presentation')
}
}
}

// ----
// init
// ----
TableBlock.init('.wp-block-table')

// ----
// export
// ----
export default TableBlock
1 change: 1 addition & 0 deletions src/js/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@ import './classes/ButtonSeoClick'
import './classes/Header'
import './classes/Animation'
import './classes/ImageBlock'
import './classes/TableBlock'
17 changes: 17 additions & 0 deletions src/scss/06-blocks/core/_table.scss
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,27 @@
width: 100%;
min-width: 240px;
border-collapse: collapse;

th {
font-weight: 700;
}

figcaption,
caption {
margin-bottom: var(--spacing--block-1);
font-size: var(--paragraph--font-size-default);
font-weight: 700;
line-height: var(--paragraph--line-height-default);
text-align: left;
}
}

.wp-block-table {
@extend %table;

display: flex;
flex-direction: column-reverse;
align-items: flex-start;
}

// Not apply style to ACF fields
Expand Down
Loading