-
Notifications
You must be signed in to change notification settings - Fork 36
Expose a JavaScript API in brokered Webviews to facilitate Improved Same Device NumberMatch , Fixes AB#3203956 #2617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fadidurah
wants to merge
8
commits into
dev
Choose a base branch
from
fadi/numberMatch
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Work item link check complete. Description contains link AB#3203956 to an Azure Boards work item. |
1 similar comment
✅ Work item link check complete. Description contains link AB#3203956 to an Azure Boards work item. |
shahzaibj
reviewed
Apr 2, 2025
...in/java/com/microsoft/identity/common/internal/numberMatch/NumberMatchJavaScriptInterface.kt
Outdated
Show resolved
Hide resolved
shahzaibj
reviewed
Apr 2, 2025
...in/java/com/microsoft/identity/common/internal/numberMatch/NumberMatchJavaScriptInterface.kt
Outdated
Show resolved
Hide resolved
shahzaibj
reviewed
Apr 2, 2025
...in/java/com/microsoft/identity/common/internal/numberMatch/NumberMatchJavaScriptInterface.kt
Outdated
Show resolved
Hide resolved
shahzaibj
reviewed
Apr 2, 2025
...va/com/microsoft/identity/common/internal/providers/oauth2/WebViewAuthorizationFragment.java
Outdated
Show resolved
Hide resolved
somalaya
reviewed
Apr 11, 2025
...in/java/com/microsoft/identity/common/internal/numberMatch/NumberMatchJavaScriptInterface.kt
Outdated
Show resolved
Hide resolved
somalaya
approved these changes
Apr 11, 2025
shahzaibj
reviewed
Apr 15, 2025
...in/java/com/microsoft/identity/common/internal/numberMatch/NumberMatchJavaScriptInterface.kt
Outdated
Show resolved
Hide resolved
shahzaibj
reviewed
Apr 15, 2025
...in/java/com/microsoft/identity/common/internal/numberMatch/NumberMatchJavaScriptInterface.kt
Outdated
Show resolved
Hide resolved
shahzaibj
reviewed
Apr 15, 2025
...in/java/com/microsoft/identity/common/internal/numberMatch/NumberMatchJavaScriptInterface.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPEC: https://microsoft-my.sharepoint-df.com/:w:/r/personal/siddhijain_microsoft_com/_layouts/15/Doc.aspx?sourcedoc=%7BD1D944D5-2047-40AB-B8F9-98506BF212A3%7D&file=Engineering%20design%20-%20Number%20matching%20on%20same%20device.docx&action=default&mobileredirect=true&share=IQHVRNnRRyCrQLj5mFBr8hKjAbj81fEnpO6X-99laqs2j_M&wdOrigin=TEAMS-MAGLEV.p2p_ns.rwc&wdExp=TEAMS-TREATMENT&wdhostclicktime=1743094076241&web=1
Structure has changed a bit for this. To facilitate future work, we will have a generalized JavaScript API that takes in a json string payload. This is used to parse out a function name, and data field, both of which are used to call a specific function in broker code. This same functionality will be used next month for CA Block improvment work (I don't have a spec to this one yet).
Expected method call in JavaScript is now something like this, we are working on finalizing json schema:
BrokerJS.postToBroker('{function: NUMBER_MATCH,data: {sessionID: id, numberMatch: number}}')
I added some unit tests in the broker PR, but primary validation will be when ests exposes a test slice that calls the JavaScript API. Did some testing in our webview class to call javascript code, and was able to prompt the numberMatch method.
Broker PR: https://github.com/AzureAD/ad-accounts-for-android/pull/3073
AB#3203956