Sync eng/common directory with azure-sdk-tools for PR 10467 #2528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azure-sdk
added
EngSys
There was a problem hiding this comment.
Pull Request Overview
This pull request synchronizes the eng/common directory with changes from the azure-sdk-tools repository, specifically updating the publish-1es-artifact pipeline template.
- Updates the comment to reflect that SBOM generation is disabled for public validation builds.
- Introduces a new condition that disables SBOM generation when the System.TeamProject variable equals "public".
Comments suppressed due to low confidence (1)
eng/common/pipelines/templates/steps/publish-1es-artifact.yml:34
- Verify that the new condition based solely on 'System.TeamProject' covers all intended scenarios, especially for forked PR builds, since the previous logic also considered the pull request reason and fork status.
# Disable sbom generation by default for our public validation builds to avoid unnecessary work
weshaggard
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#10467 See eng/common workflow