Skip to content

Transform : Add opt for src=tgt #1188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

abhilash1910
Copy link

Adds in the optimization to rewrite "tgt /\ (src -> foo)" to "tgt /\ foo" if src=tgt .
Tested against existing and newer opt.ll cases.
@regehr @nunoplopes please help to review, thanks.

@nunoplopes
Copy link
Member

I don't understand this patch. It removes the existing optimization despite claiming it adds a new optimization

@nunoplopes nunoplopes closed this Apr 21, 2025
@abhilash1910
Copy link
Author

@nunoplopes , yes this aims to target the commented opt path where src = tgt. For src!=tgt the default opt path is taken (in else). Initially I only did pre_tgt = pre_tgt_and() inside the if() to make it tgt ^foo, but this did not look after pre_src, hence added it . Could you help to suggest on a better way to add it ? Thanks.

@nunoplopes
Copy link
Member

Does this give any perf benefit?

@abhilash1910
Copy link
Author

I am checking on this for perf enhancements. Will report here , thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants