subscription_list: Show a dot for unreads if channel is muted

Fixes: #712

Author: Khader-1

lib/widgets/subscription_list.dart

@@ -189,8 +189,11 @@ class _SubscriptionList extends StatelessWidget {
       itemBuilder: (BuildContext context, int index) {
         final subscription = subscriptions[index];
         final unreadCount = unreadsModel!.countInChannel(subscription.streamId);
-        // TODO(#712): if stream muted, show a dot for unreads
-        return SubscriptionItem(subscription: subscription, unreadCount: unreadCount);
+        final showMutedUnreadBadge = unreadCount == 0
+          && unreadsModel!.countInChannelNarrow(subscription.streamId) > 0;
+        return SubscriptionItem(subscription: subscription,
+          unreadCount: unreadCount,
+          showMutedUnreadBadge: showMutedUnreadBadge);
     });
   }
 }
@@ -201,10 +204,12 @@ class SubscriptionItem extends StatelessWidget {
     super.key,
     required this.subscription,
     required this.unreadCount,
+    required this.showMutedUnreadBadge,
   });
 
   final Subscription subscription;
   final int unreadCount;
+  final bool showMutedUnreadBadge;
 
   @override
   Widget build(BuildContext context) {
@@ -250,7 +255,7 @@ class SubscriptionItem extends StatelessWidget {
                   maxLines: 1,
                   overflow: TextOverflow.ellipsis,
                   subscription.name)))),
-          if (unreadCount > 0) ...[
+          if (hasUnreads) ...[
             const SizedBox(width: 12),
             // TODO(#747) show @-mention indicator when it applies
             Opacity(
@@ -259,6 +264,10 @@ class SubscriptionItem extends StatelessWidget {
                 count: unreadCount,
                 backgroundColor: swatch,
                 bold: true)),
+          ] else if (showMutedUnreadBadge) ...[
+            const SizedBox(width: 12),
+            // TODO(#747) show @-mention indicator when it applies
+            const MutedUnreadBadge(),
           ],
           const SizedBox(width: 16),
         ])));

lib/widgets/unread_count_badge.dart

@@ -57,3 +57,18 @@ class UnreadCountBadge extends StatelessWidget {
           count.toString())));
   }
 }
+
+class MutedUnreadBadge extends StatelessWidget {
+  const MutedUnreadBadge({super.key});
+
+  @override
+  Widget build(BuildContext context) {
+    return Container(
+      width: 8,
+      height: 8,
+      margin: const EdgeInsetsDirectional.only(end: 3),
+      decoration: BoxDecoration(
+        color: const HSLColor.fromAHSL(0.5, 0, 0, 0.8).toColor(),
+        shape: BoxShape.circle));
+  }
+}

test/widgets/subscription_list_test.dart

@@ -154,6 +154,7 @@ void main() {
       eg.subscription(stream),
     ], unreadMsgs: unreadMsgs);
     check(find.byType(UnreadCountBadge).evaluate()).length.equals(1);
+    check(find.byType(MutedUnreadBadge).evaluate().length).equals(0);
   });
 
   testWidgets('unread badge counts unmuted only', (tester) async {
@@ -174,6 +175,7 @@ void main() {
     check(tester.widget<Text>(find.descendant(
         of: find.byType(UnreadCountBadge), matching: find.byType(Text))))
       .data.equals('1');
+    check(find.byType(MutedUnreadBadge).evaluate().length).equals(0);
   });
 
   testWidgets('unread badge does not show with no unreads', (tester) async {
@@ -183,6 +185,46 @@ void main() {
       eg.subscription(stream),
     ], unreadMsgs: unreadMsgs);
     check(find.byType(UnreadCountBadge).evaluate()).length.equals(0);
+    check(find.byType(MutedUnreadBadge).evaluate().length).equals(0);
+  });
+
+  testWidgets('muted unread badge shows when unreads are visible in channel but not inbox', (tester) async {
+    final stream = eg.stream();
+    final unreadMsgs = eg.unreadMsgs(channels: [
+      UnreadChannelSnapshot(streamId: stream.streamId, topic: 'b', unreadMessageIds: [3]),
+    ]);
+    await setupStreamListPage(tester,
+      subscriptions: [eg.subscription(stream, isMuted: true)],
+      userTopics: [eg.userTopicItem(stream, 'b', UserTopicVisibilityPolicy.none)],
+      unreadMsgs: unreadMsgs);
+
+    check(find.byType(MutedUnreadBadge).evaluate().length).equals(1);
+  });
+
+  testWidgets('muted unread badge does not show when unreads are visible in both channel & inbox', (tester) async {
+    final stream = eg.stream();
+    final unreadMsgs = eg.unreadMsgs(channels: [
+      UnreadChannelSnapshot(streamId: stream.streamId, topic: 'b', unreadMessageIds: [3]),
+    ]);
+    await setupStreamListPage(tester,
+      subscriptions: [eg.subscription(stream, isMuted: false)],
+      userTopics: [eg.userTopicItem(stream, 'b', UserTopicVisibilityPolicy.none)],
+      unreadMsgs: unreadMsgs);
+
+    check(find.byType(MutedUnreadBadge).evaluate().length).equals(0);
+  });
+
+  testWidgets('muted unread badge does not show when unreads are not visible in channel nor inbox', (tester) async {
+    final stream = eg.stream();
+    final unreadMsgs = eg.unreadMsgs(channels: [
+      UnreadChannelSnapshot(streamId: stream.streamId, topic: 'b', unreadMessageIds: [3]),
+    ]);
+    await setupStreamListPage(tester,
+      subscriptions: [eg.subscription(stream, isMuted: true)],
+      userTopics: [eg.userTopicItem(stream, 'b', UserTopicVisibilityPolicy.muted)],
+      unreadMsgs: unreadMsgs);
+
+    check(find.byType(MutedUnreadBadge).evaluate().length).equals(0);
   });
 
   testWidgets('color propagates to icon and badge', (tester) async {