tests: posix: rwlocks: ensure test is not skipped #88767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfriedt
force-pushed
the
tests-posix-rwlocks-skipped
branch
from
f64a873 to
15cf8e2
Compare
cfriedt
added
the
area: Tests
ycsin
previously approved these changes
Apr 17, 2025
| @@ -3,3 +3,7 @@ CONFIG_ZTEST=y | |||
|
|
|||
| CONFIG_POSIX_AEP_CHOICE_BASE=y | |||
| CONFIG_POSIX_READER_WRITER_LOCKS=y | |||
|
|
|||
| CONFIG_DYNAMIC_THREAD=y | |||
| CONFIG_DYNAMIC_THREAD_POOL_SIZE=3 | |||
There was a problem hiding this comment.
I wonder if we should BUILD_ASSERT(CONFIG_DYNAMIC_THREAD_POOL_SIZE >= N_THR)?
Commit 7e8ee25 moved the tests for the POSIX_RW_LOCKS Option Group from the tests/posix/common testsuite to its own dedicated testsuite. However, there was a copy-paste error. Previously, tests would have been run only once when dynamic threads were enabled, and then skipped when dynamic threads were disabled, since that follows the posix programming model better. However, dynamic threads were never actually enabled after moving to the new testsuite. So all tests were effectively skipped. Add the necessary options to prj.conf in order to ensure that there are sufficient dynamic threads available to run the testsuite. Signed-off-by: Chris Friedt <cfriedt@tenstorrent.com>
cfriedt
force-pushed
the
tests-posix-rwlocks-skipped
branch
from
15cf8e2 to
766ad8a
Compare
ycsin
approved these changes
Apr 18, 2025
jukkar
approved these changes
Apr 19, 2025
JordanYates
approved these changes
Apr 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 7e8ee25 moved the tests for the
POSIX_RW_LOCKSOption Group fromtests/posix/commontestsuite totests/posix/rwlocks.However, there was a copy-paste error. Previously, tests would have been run only once when dynamic threads were enabled, and then skipped when dynamic threads were disabled, since that follows the posix programming model better. However, dynamic threads were never actually enabled after moving to the new testsuite. So all tests were effectively skipped.
Add the necessary options to
prj.confin order to ensure that there are sufficient dynamic threads available to run the testsuite.Fixes #88766