Skip to content

tests: posix: rwlocks: all tests skipped due to copy-paste error #88766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cfriedt opened this issue Apr 17, 2025 · 0 comments · May be fixed by #88767
Open

tests: posix: rwlocks: all tests skipped due to copy-paste error #88766

cfriedt opened this issue Apr 17, 2025 · 0 comments · May be fixed by #88767
Assignees
Labels
area: POSIX POSIX API Library area: Tests Issues related to a particular existing or missing test bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@cfriedt
Copy link
Member

cfriedt commented Apr 17, 2025

Describe the bug
Previously, the POSIX_RW_LOCKS Option Group was lumped-in with the tests/posix/common testsuite. That testsuite had a bit of a "CI optimization" so as to not run the tests twice (once with dynamic threads enabled, and once without).

The testsuite was copied over, and so was the "hack" to optimize CI. However, without properly ensuring that dynamic threads were configured properly, all tests were skipped.

I think a good policy for some contributors would be to fill in a "Testing Done" section in pull-requests, to verify that tests are actually executing the way that one one would expect.

Please also mention any information which could help others to understand
the problem you're facing:

  • What target platform are you using? any
  • What have you tried to diagnose or workaround this issue? found the root cause and solution
  • Is this a regression? Yes, 7e8ee25

To Reproduce

  1. west build -p auto -b qemu_riscv64 -t run tests/posix/rwlocks
  2. See that tests are skipped

Expected behavior
All tests should run and succeed.

Impact
The impact of this bug is low, since tests were passing before and after the fix.

Logs and console output

*** Booting Zephyr OS build v4.1.0-2563-g90cd350c5a4a ***
Running TESTSUITE posix_rw_locks
===================================================================
START - test_pthread_rwlockattr_getpshared
 SKIP - test_pthread_rwlockattr_getpshared in 0.001 seconds
===================================================================
START - test_pthread_rwlockattr_setpshared
 SKIP - test_pthread_rwlockattr_setpshared in 0.001 seconds
===================================================================
START - test_rw_lock
 SKIP - test_rw_lock in 0.001 seconds
===================================================================
TESTSUITE posix_rw_locks succeeded

------ TESTSUITE SUMMARY START ------

SUITE SKIP -   0.00% [posix_rw_locks]: pass = 0, fail = 0, skip = 3, total = 3 duration = 0.003 seconds
 - SKIP - [posix_rw_locks.test_pthread_rwlockattr_getpshared] duration = 0.001 seconds
 - SKIP - [posix_rw_locks.test_pthread_rwlockattr_setpshared] duration = 0.001 seconds
 - SKIP - [posix_rw_locks.test_rw_lock] duration = 0.001 seconds

------ TESTSUITE SUMMARY END ------

===================================================================
PROJECT EXECUTION SUCCESSFUL

Environment (please complete the following information):

  • OS: Any
  • Toolchain (e.g Zephyr SDK, ...): Zephyr SDK v0.17.0
  • Commit SHA or Version used: 90cd350

Additional context

@cfriedt cfriedt added area: POSIX POSIX API Library bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug labels Apr 17, 2025
@cfriedt cfriedt self-assigned this Apr 17, 2025
@cfriedt cfriedt linked a pull request Apr 17, 2025 that will close this issue
@cfriedt cfriedt added the area: Tests Issues related to a particular existing or missing test label Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: POSIX POSIX API Library area: Tests Issues related to a particular existing or missing test bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant