Skip to content

Consolidate initalizing Ops classes #2111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tw4l opened this issue Oct 10, 2024 · 0 comments · Fixed by #2117
Closed

Consolidate initalizing Ops classes #2111

tw4l opened this issue Oct 10, 2024 · 0 comments · Fixed by #2117
Assignees

Comments

@tw4l
Copy link
Member

tw4l commented Oct 10, 2024

#2098 introduced a new main_bg entrypoint for background jobs that require access to our ops classes. This means we now have up to three places to update each time we change the signature for the ops classes init methods.

We should consolidate these, perhaps with a util function, to reduce the overhead of making changes and the likelihood of regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant