Skip to content

Error in Success Criterion 1.3.4 Orientation Note #4346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ryukochan opened this issue Apr 17, 2025 · 2 comments · May be fixed by #4349
Open

Error in Success Criterion 1.3.4 Orientation Note #4346

ryukochan opened this issue Apr 17, 2025 · 2 comments · May be fixed by #4349

Comments

@ryukochan
Copy link

I believe the Note to Success Criterion 1.3.4 Orientation is made incorrect by inclusion of the word 'not.'
Due to the essential orientation of the provided examples, the note should read:

Examples where a particular display orientation may be essential are a bank check, a piano application, slides for a projector or television, or virtual reality content where content is necessarily restricted to landscape or portrait display orientation.

Image

The word 'not' was apparently inserted via an erratum in PR #734 in May of 2019.
@patrickhlauke
Copy link
Member

agree the "not" there is not correct. not sure #734 is to blame. it seems f9a2821 included a rewrite/simplification of original wording

where binary display orientation is not applicable

into simpler language, and in the process the meaning was accidentally flipped on its head

where content is not necessarily restricted to landscape or portrait display orientation

/cc @alastc

patrickhlauke added a commit that referenced this issue Apr 18, 2025
@patrickhlauke
Remove incorrect "not" from 1.3.4 Orientation note
75eb5b0 
The "not" was introduced as part of f9a2821 which rewrote the example from an early draft into simpler language, and in doing so accidentally flipped the meaning from `where binary display orientation is not applicable` to `where content is NOT necessarily restricted to landscape or portrait orientation`

Closes #4346
@patrickhlauke patrickhlauke mentioned this issue Apr 18, 2025
Closed
@patrickhlauke
Copy link
Member

Filed #4348

patrickhlauke added a commit that referenced this issue Apr 18, 2025
@patrickhlauke
Remove the confusing "not necessarily limited" part of the 1.3.4 Orie…
47a20a2 
…ntation note and expand

Follow-up to #4348

Assuming that the `here content is NOT necessarily restricted to landscape or portrait orientation` relates just to the virtual reality example, this expands what was meant (at least, my understanding of it)

Closes #4346
@patrickhlauke patrickhlauke linked a pull request Apr 18, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@patrickhlauke @ryukochan