Skip to content

Commit 8de9dc6

Browse files
authored
fix: handle falsy srcset values (#8901)
fixes #8899
1 parent 58e95c6 commit 8de9dc6

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed

Diff for: .changeset/early-lizards-decide.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'svelte': patch
3+
---
4+
5+
fix: handle falsy srcset values

Diff for: packages/svelte/src/runtime/internal/utils.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -90,12 +90,12 @@ function split_srcset(srcset) {
9090

9191
/**
9292
* @param {HTMLSourceElement | HTMLImageElement} element_srcset
93-
* @param {string} srcset
93+
* @param {string | undefined | null} srcset
9494
* @returns {boolean}
9595
*/
9696
export function srcset_url_equal(element_srcset, srcset) {
9797
const element_urls = split_srcset(element_srcset.srcset);
98-
const urls = split_srcset(srcset);
98+
const urls = split_srcset(srcset || '');
9999

100100
return (
101101
urls.length === element_urls.length &&

Diff for: packages/svelte/test/utils/utils.test.js

+1
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,7 @@ describe('utils', () => {
162162
it('should return false if urls are different', () => {
163163
assert.notOk(srcset_url_equal(create_element('a 1x'), 'b 1x'));
164164
assert.notOk(srcset_url_equal(create_element('a 2x'), 'a 1x'));
165+
assert.notOk(srcset_url_equal(create_element('a 2x'), null));
165166
});
166167
});
167168
});

0 commit comments

Comments
 (0)