Addon Vitest: Fix watch mode for new files #31156
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
5 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
376
to
377
| // This function not onlye test a file matches the test globs, but it also | ||
| // adds the file to the project's internal testFilesList |
There was a problem hiding this comment.
syntax: typo in comment: 'onlye' should be 'only'
Suggested change
| // This function not onlye test a file matches the test globs, but it also | |
| // adds the file to the project's internal testFilesList | |
| // This function not only test a file matches the test globs, but it also | |
| // adds the file to the project's internal testFilesList |
Comment on lines
32
to
36
| export type InternalOptions = Required<UserOptions> & { | ||
| debug: boolean; | ||
| tags: Required<UserOptions['tags']>; | ||
| includeStories: string[]; | ||
| }; |
There was a problem hiding this comment.
style: Consider documenting the includeStories property with JSDoc like the other properties
|
|
||
| return relativeToViteRoot; | ||
| }) | ||
| .filter((story) => story.replace('mdx|stories', 'stories')); |
There was a problem hiding this comment.
logic: The replace call here won't work as intended - it only replaces the first occurrence and returns a new string without modifying the original. Should use a regex with global flag: /mdx|stories/g
Suggested change
| .filter((story) => story.replace('mdx|stories', 'stories')); | |
| .filter((story) => story.replace(/mdx|stories/g, 'stories')); |
yannbf
approved these changes
Apr 17, 2025
|
View your CI Pipeline Execution ↗ for commit da2f21a.
☁️ Nx Cloud last updated this comment at |
yannbf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #31100
What I did
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
This PR improves file watching functionality in the Storybook Vitest addon, particularly focusing on proper detection and testing of newly added files.
vitest-manager.tsto distinguish between 'add' and 'change' eventsmatchesTestGlobcall inrunAffectedTestsAfterChangeto properly register new test filestinyglobbywithmicromatchfor more reliable file pattern matchingincludeStoriestoInternalOptionsfor better control over story inclusionDEFAULT_FILES_PATTERNfrom normalize-stories for consistent file matching across the codebase