Skip to content

Create 'Effect.js' Superclass #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ogbabydiesal opened this issue Jun 10, 2024 · 1 comment
Open

Create 'Effect.js' Superclass #15

ogbabydiesal opened this issue Jun 10, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@ogbabydiesal
Copy link
Collaborator

ogbabydiesal commented Jun 10, 2024

derived classes would include effects such as Delay, Reverb, etc..

the benefit of this is that we can inherit methods such as wetdry() and amp()

@ogbabydiesal ogbabydiesal added the enhancement New feature or request label Jun 10, 2024
@lvdopqt
Copy link

lvdopqt commented Apr 5, 2025

Hello again
I've started this change in this branch. I've created an effects folder and changed the import reference in the app entrypoint. For now I've just moved the connect/disconnect functions to this Effect.js superclass, but maybe it could be moved to a more generic "Node" superclass.
I didnt implement wetdry() and amp() or other functions for now, but the structure is ~ready for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants