atnd5 Menu component - add support for default selected keys #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
The commit has been merged: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONTEXT
The Antd Menu component is well-suited for building the navigation menu for a website or app being created in Plasmic studio.
Of course, when building a website navigation bar, it's important to show the user what page they are currently on
The default selected keys prop of the antd menu component allows specification of the default (initially selected) menu items.
PROBLEM
The existing Plasmic code component registratoin for antd5 Menu component does not allow the user to specify the default selected keys prop of the Antd Menu component.
SOLUTION
This PR adds support for the missing prop.
This allows Plasmic studio users to flexibly control which menu item/s are selected when the component first loads.
In the context of creating an app/website navigation menu, here is an example of how this new prop can be used effectively:
2024-08-16.15-24-30.-.Menu.default.selected.key.option.mp4