Skip to content

Implement onPressIn property for TextInput for fabric #13127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jonthysell opened this issue Apr 29, 2024 · 1 comment · May be fixed by #14480
Open

Implement onPressIn property for TextInput for fabric #13127

jonthysell opened this issue Apr 29, 2024 · 1 comment · May be fixed by #14480
Assignees
@HariniMalothu17
Labels
API: Completion Area: Component Views Area: Fabric Support Facebook Fabric Area: TextInput enhancement good first issue: easy New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric Parity: Fabric vs. Paper RNW Fabric does not look or behave like RNW Paper Workstream: Component Parity Close the parity gap between RNW and RN for core RN components and their supporting APIs.
Milestone
Next

Comments

@jonthysell
Copy link
Contributor

Implement the onPressIn property for the fabric implementation of TextInput.

This property was available in RNW Paper via TextInputViewManager.

See https://reactnative.dev/docs/textinput#onpressin for details.
@jonthysell jonthysell added API: Completion Area: Component Views Area: Fabric Support Facebook Fabric Area: TextInput enhancement New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric Parity: Fabric vs. Paper RNW Fabric does not look or behave like RNW Paper labels Apr 29, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Apr 29, 2024
@chrisglein chrisglein added this to the Backlog milestone Apr 30, 2024
@chrisglein chrisglein removed the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Apr 30, 2024
@chiaramooney chiaramooney added the Workstream: Component Parity Close the parity gap between RNW and RN for core RN components and their supporting APIs. label Oct 3, 2024
@chiaramooney chiaramooney modified the milestones: Backlog, Next Mar 5, 2025
@TatianaKapos
Copy link
Contributor

WindowsTextInputComponentView.cpp already has code that follow pointerpress, it may just need to call the event too? If so, this change would be <5 lines

@HariniMalothu17 HariniMalothu17 self-assigned this Apr 3, 2025
@HariniMalothu17 HariniMalothu17 linked a pull request Apr 3, 2025 that will close this issue
Open
@similar-issues-ai similar-issues-ai bot mentioned this issue Apr 17, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HariniMalothu17 HariniMalothu17

Labels
API: Completion Area: Component Views Area: Fabric Support Facebook Fabric Area: TextInput enhancement good first issue: easy New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric Parity: Fabric vs. Paper RNW Fabric does not look or behave like RNW Paper Workstream: Component Parity Close the parity gap between RNW and RN for core RN components and their supporting APIs.
Projects
RNW New Architecture
Status: No status
Milestone
Next
5 participants
@jonthysell @chrisglein @chiaramooney @TatianaKapos @HariniMalothu17