Skip to content

Bug with background.js in lesson 5-3 extension icon #1391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
EdmondsNathan opened this issue Apr 2, 2025 · 0 comments · May be fixed by #1392
Open

Bug with background.js in lesson 5-3 extension icon #1391

EdmondsNathan opened this issue Apr 2, 2025 · 0 comments · May be fixed by #1392

Comments

@EdmondsNathan
Copy link

Describe the bug
In lesson 5-3, there are two lines of code that need to be changed. In the background.js file, line 3 and line 11 give errors, causing the extension's icon to not update colors correctly.

To Reproduce
Follow the guide for lesson 5-3 normally and then build and run the extension

Expected behavior
The extension icon should change colors automatically

Screenshots

Image

Desktop:

  • OS: Windows 11
  • Browser Brave
  • Version 1.76.82 Chromium: 134.0.6998.178 (Official Build) (64-bit)
EdmondsNathan added a commit to EdmondsNathan/Web-Dev-For-Beginners that referenced this issue Apr 2, 2025
@EdmondsNathan
Fix bug with displaying browser extension icon
1d915fb 
Resolves issue microsoft#1391 by updating `browserAction` to `action` and changing `document.createElement('canvas')` to `new offscreenCanvas(200, 200);`
@EdmondsNathan EdmondsNathan linked a pull request Apr 2, 2025 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue #1391 with displaying browser extension icon EdmondsNathan/Web-Dev-For-Beginners
1 participant
@EdmondsNathan