Skip to content

Support --health-probe-bind-addr flag in helm chart #4136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
niclask25 opened this issue Apr 9, 2025 · 1 comment
Open

Support --health-probe-bind-addr flag in helm chart #4136

niclask25 opened this issue Apr 9, 2025 · 1 comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@niclask25
Copy link

Describe the feature you are requesting
Support --health-probe-bind-addr flag in helm chart, since that one is missing

Describe the proposed solution you'd like

  1. Add healthProbeBindAddr as helm chart value.
  2. Add --health-probe-bind-addr to args: in deployment.yaml
  3. Set value of readinessProbe and livenessProbe port to healthProbeBindAddr

Contribution Intention (Optional)

-[ x ] Yes, I am willing to contribute a PR to implement this feature
-[ ] No, I cannot work on a PR at this time
@shraddhabang shraddhabang added kind/feature Categorizes issue or PR as related to a new feature. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Apr 9, 2025
@shraddhabang
Copy link
Collaborator

@niclask25 I think this will be a good value add for the controller. Please feel free to open a PR for it. Thanks.

This was referenced Apr 10, 2025
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shraddhabang @niclask25