Skip to content

Support --default-load-balancer-scheme flag in helm chart #4085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andremarianiello opened this issue Mar 11, 2025 · 4 comments
Open

Support --default-load-balancer-scheme flag in helm chart #4085

andremarianiello opened this issue Mar 11, 2025 · 4 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@andremarianiello
Copy link

Describe the feature you are requesting
Support --default-load-balancer-scheme flag in helm chart. Many of the controller flags are exposed as helm chart values, but not this one.

Motivation
I want to change the default load balancer scheme to internet-facing so that some services that I cannot set annotations on are automatically made internet facing.

Describe the proposed solution you'd like
Expose the --default-load-balancer-scheme as a helm chart value

Describe alternatives you've considered
The service I want to be internet-facing is created by a controller, and the controller does not have the ability to add custom annotations to the service. I also don't want to install a whole mutating webhook solution just to add the annotation when the controller itself already supports changing the default scheme. Additionally, I don't see a way to set this flag via environment variable.

Contribution Intention (Optional)

-[ x ] Yes, I am willing to contribute a PR to implement this feature
-[ ] No, I cannot work on a PR at this time

@sarevalo2002
Copy link
Contributor

That's a good idea, you're welcome to contribute a PR for the feature and we'll take a look once it's made. It should be a fairly simple change.

@wweiwei-li wweiwei-li added triage/accepted Indicates an issue or PR is ready to be actively worked on. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Mar 12, 2025
@ysam12345
Copy link
Contributor

Hi, I can work on this if no one is working on it yet.

@andremarianiello
Copy link
Author

I'm not!

@ysam12345
Copy link
Contributor

Cool, I will create a PR for this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

4 participants