Skip to content

Allow specifying prefix lists by names #4077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
artem-nefedov opened this issue Mar 5, 2025 · 4 comments
Open

Allow specifying prefix lists by names #4077

artem-nefedov opened this issue Mar 5, 2025 · 4 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.

Comments

@artem-nefedov
Copy link

artem-nefedov commented Mar 5, 2025

Describe the feature you are requesting

Ability to specify prefix lists by names rather than IDs.

Motivation

aws-load-balancer-security-group-prefix-lists service annotation expects you to provide prefix list IDs. This is rather inconvenient and makes us do custom-script preprocessing to convert prefix list names into IDs first. It would be much simpler if we can specify prefix list names directly.

Describe the proposed solution you'd like

New service annotation (e.g. aws-load-balancer-security-group-prefix-list-names) that accepts comma-separated list of prefix lists. Controller does the logic of looking up the names and converting them to IDs internally. IAM permissions are updated accordingly, if needed.

Accepting names in already existing annotation is also an option, as it will match the behaviour of security group annotation:

Both name and ID of securityGroups are supported. Name matches a Name tag, not the groupName attribute.

Example

service.beta.kubernetes.io/aws-load-balancer-security-groups: sg-xxxx, nameOfSg1, nameOfSg2

Describe alternatives you've considered

N/A

Contribution Intention (Optional)

-[ ] Yes, I am willing to contribute a PR to implement this feature
-[x] No, I cannot work on a PR at this time

@sarevalo2002
Copy link
Contributor

That sounds like a reasonable ask! This is a good first issue, and we welcome community contribution for it.

@wweiwei-li wweiwei-li added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Mar 12, 2025
@LucaLanziani
Copy link

/assign

@LucaLanziani
Copy link

I think I'm leaning towards having a new annotation more than overloading the existing one

@LucaLanziani
Copy link

Is there a way to test this locally with Localstack? I have some changes ready and I would like to test them without having to setup a full AWS account and EKS cluster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Projects
None yet
Development

No branches or pull requests

4 participants