Introduce ExceptionHandler extension point

[marcphilipp]

Proposal

interface ExceptionHandlerExtensionPoint extends ExtensionPoint {
   void handleException(TestExtensionContext context, Throwable throwable) throws Throwable;
}

Tasks

• Implement extension point with tests and everything
• Add example usage in documentation
• Introduce @ExpectToFail annotation in document module to allow sample test cases to fail

related to #92.

[jlink]

I'm working on it.

[sbrannen]

Cool. Looking forward to having this feature in place!

[sbrannen]

By the way, why not just call it ExceptionHandler?

I don't see the need to name all extension APIs *ExtensionPoint.

[sbrannen]

Plus, the Position won't make sense with such an ExceptionHandler: it can only be used during an after phase, which could be ordered, but there is no such concept as wrapping for a feature like this.

This of course ties in with the discussion of Position in general which we are discussing in #112.

[jlink]

IMO, position makes also sense here since an exception handler can be
closer or further away from the test method itself.

2016-01-21 13:42 GMT+01:00 Sam Brannen notifications@github.com:

Plus, the Position won't make sense with such an ExceptionHandler: it can
only be used during an after phase, which could be ordered, but there
is no such concept as wrapping for a feature like this.

This of course ties in with the discussion of Position in general which
we are discussing in #112
#112.

—
Reply to this email directly or view it on GitHub
#103 (comment).

[jlink]

I'm not sure. ExceptionHandler sounds way more generic than it actually is.
Does *ExtensionPoint hurt?

2016-01-21 13:39 GMT+01:00 Sam Brannen notifications@github.com:

By the way, why not just call it ExceptionHandler?

I don't see the need to name all extension APIs *ExtensionPoint.

—
Reply to this email directly or view it on GitHub
#103 (comment).

[sbrannen]

IMO, position makes also sense here since an exception handler can be closer or further away from the test method itself.

Yes, that's what I meant by ordering. Ordering certainly makes sense, but wrapping does not. In any case, let's address this topic in #112.

[sbrannen]

Does *ExtensionPoint hurt?

I just question our use of *ExtensionPoint in general. I'm not convinced that we need the concept of an "extension point" beyond the basic concept of an "extension".

[jlink]

Is it the same discussion we had last week or any other/new points?

Extension and ExtensionPoint have different semantics in my book. But
we have been through this argument before...

2016-01-21 15:31 GMT+01:00 Sam Brannen notifications@github.com:

Does *ExtensionPoint hurt?

I just question our use of *ExtensionPoint in general. I'm not convinced
that we need the concept of an "extension point" beyond the basic concept
of an "extension".

—
Reply to this email directly or view it on GitHub
#103 (comment).

[jlink]

Done with #0684c9c