Relax timings of subshell tests #1374
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be possible to use events instead of relying on timings? |
ianthomas23
force-pushed
the
subshell-test-timings
branch
from
62ed03a to
ef4a8e5
Compare
Well yes, the tests could be rewritten in some other way. But that is not my intention here. |
|
Tests were passing fine when I submitted this. Now that it is rebased on top of the |
|
Yes, although mostly around subshells. It could be unrelated to subshells, but since you know best how they work, maybe you could help understand the issue? |
ianthomas23
force-pushed
the
subshell-test-timings
branch
from
ef4a8e5 to
ab36bf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking into improving the flakiness of some of the subshell tests, hoping to fix #1359.
The failures in CI all appear on Windows, either CPython 3.11 or PyPy. On a local Windows machine the tests pass for my using CPython 3.11 but I can reproduce the failures with PyPy 3.9. Increasing the timings of the tests so that the timing variability is proportionately smaller works for me locally, so trying it here in CI.