Skip to content

showsVerticalScrollIndicator Prop missing in SetProp for ScrollView #50779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anupriya13 opened this issue Apr 17, 2025 · 4 comments
Closed

showsVerticalScrollIndicator Prop missing in SetProp for ScrollView #50779

anupriya13 opened this issue Apr 17, 2025 · 4 comments
Labels
Needs: Attention Issues where the author has responded to feedback. Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue.

Comments

@anupriya13
Copy link
Contributor

Description

RAW_SET_PROP_SWITCH_CASE_BASIC(showsHorizontalScrollIndicator);

Need to add RAW_SET_PROP_SWITCH_CASE_BASIC(showsVerticalScrollIndicator); as it's missing

Related PR: microsoft/react-native-windows#14526

Steps to reproduce

Pass showsVerticalScrollIndicator in RNW for Scroll View

React Native Version

0.78.2

Affected Platforms

Build - Windows

Output of npx @react-native-community/cli info

info Fetching system and libraries information...
System:
  OS: Windows 11 10.0.22631
  CPU: (16) x64 Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
  Memory: 24.59 GB / 63.95 GB
Binaries:
  Node:
    version: 18.18.0
    path: C:\Program Files\nodejs\node.EXE
  Yarn:
    version: 1.22.22
    path: C:\Program Files (x86)\Yarn\bin\yarn.CMD
  npm:
    version: 9.8.1
    path: C:\Program Files\nodejs\npm.CMD
  Watchman: Not Found
SDKs:
  Android SDK: Not Found
  Windows SDK:
    AllowDevelopmentWithoutDevLicense: Enabled
    AllowAllTrustedApps: Enabled
    Versions:
      - 10.0.17763.0
      - 10.0.18362.0
      - 10.0.19041.0
      - 10.0.22000.0
      - 10.0.22621.0
      - 10.0.26100.0
IDEs:
  Android Studio: Not Found
  Visual Studio:
    - 17.13.35828.75 (Visual Studio Enterprise 2022)
    - 17.13.35828.75 (Visual Studio Community 2022)
Languages:
  Java: Not Found
  Ruby: Not Found
npmPackages:
  "@react-native-community/cli": Not Found
  react: Not Found
  react-native: Not Found
  react-native-windows: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: Not found
  newArchEnabled: Not found
iOS:
  hermesEnabled: Not found
  newArchEnabled: Not found

Stacktrace or Logs

info Fetching system and libraries information...
System:
  OS: Windows 11 10.0.22631
  CPU: (16) x64 Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
  Memory: 24.59 GB / 63.95 GB
Binaries:
  Node:
    version: 18.18.0
    path: C:\Program Files\nodejs\node.EXE
  Yarn:
    version: 1.22.22
    path: C:\Program Files (x86)\Yarn\bin\yarn.CMD
  npm:
    version: 9.8.1
    path: C:\Program Files\nodejs\npm.CMD
  Watchman: Not Found
SDKs:
  Android SDK: Not Found
  Windows SDK:
    AllowDevelopmentWithoutDevLicense: Enabled
    AllowAllTrustedApps: Enabled
    Versions:
      - 10.0.17763.0
      - 10.0.18362.0
      - 10.0.19041.0
      - 10.0.22000.0
      - 10.0.22621.0
      - 10.0.26100.0
IDEs:
  Android Studio: Not Found
  Visual Studio:
    - 17.13.35828.75 (Visual Studio Enterprise 2022)
    - 17.13.35828.75 (Visual Studio Community 2022)
Languages:
  Java: Not Found
  Ruby: Not Found
npmPackages:
  "@react-native-community/cli": Not Found
  react: Not Found
  react-native: Not Found
  react-native-windows: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: Not found
  newArchEnabled: Not found
iOS:
  hermesEnabled: Not found
  newArchEnabled: Not found

Reproducer

microsoft/react-native-windows#14526

Screenshots and Videos

Image

@react-native-bot react-native-bot added Needs: Author Feedback Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. labels Apr 17, 2025
@anupriya13 anupriya13 changed the title Prop missing in SetProps showsVerticalScrollIndicator Prop missing in SetProps for ScrollView Apr 17, 2025
@react-native-bot
Copy link
Collaborator

Warning

Missing reproducer: We could not detect a reproducible example in your issue report. Please provide either:

@anupriya13 anupriya13 changed the title showsVerticalScrollIndicator Prop missing in SetProps for ScrollView showsVerticalScrollIndicator Prop missing in SetProp for ScrollView Apr 17, 2025
@anupriya13
Copy link
Contributor Author

anupriya13 commented Apr 17, 2025

Check this PR microsoft/react-native-windows#14526
I had to locally update my node_modules file to make it work. Would appreciate the fix to be made in react-native/packages/react-native/ReactCommon/react/renderer/components/scrollview/ScrollViewProps.cpp file and add RAW_SET_PROP_SWITCH_CASE_BASIC(showsVerticalScrollIndicator); as it's missing

@github-actions github-actions bot added Needs: Attention Issues where the author has responded to feedback. and removed Needs: Author Feedback labels Apr 17, 2025
@NickGerleman
Copy link
Contributor

NickGerleman commented Apr 18, 2025

Would appreciate the fix to be made in react-native/packages/react-native/ReactCommon/react/renderer/components/scrollview/ScrollViewProps.cpp file and add RAW_SET_PROP_SWITCH_CASE_BASIC(showsVerticalScrollIndicator); as it's missing

Please feel free to make a PR adding this. Iterator style props parser is not generally enabled, so this issue does not effect end user iOS or Android applications, but it would be good to fix nonetheless.

@anupriya13
Copy link
Contributor Author

@NickGerleman Added the fix here: #50798

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Attention Issues where the author has responded to feedback. Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants