-
-
Notifications
You must be signed in to change notification settings - Fork 9k
Canary versions are treated as older than the latest stable version #11013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Agree we should probably do that. I've seen React and Next.js bumping to the next minor version instead, it's probably better than a patch. |
Stable versions of React or Next other than x.y.0 are "backport" versions. |
I'm not sure I understand what you try to say 🤔 What I want is to be clear that the canary version is not the "upcoming patch" but may contain new features, and eventually breaking changes too. |
In Next.js, x.y.n (n ≠ 0) are independent of the main branch. |
Next has |
Since some new features have already been introduced in main since 3.7.0, we can bump the minor version as for now (at least until 3.8.0 is released). |
That's true, but we used to have backport branches and got rid of that as it was too time consuming to manage. I don't think the way we organize releases/commit should really impact the canary versioning scheme though. We don't want to update the canary script every time we merge a new patch/minor/major commit. Always bumping to the next minor version is not 100% accurate, but is likely a decent choice that would work in most cases, and solves the reported CLI warning. Even if we have only merged patch commits, that doesn't seem like a big deal. And when merging breaking changes, we can remember to update the script once in a while. |
We may as well try the minor version bumping strategy first as you say. |
Have you read the Contributing Guidelines on issues?
Prerequisites
npm run clear
oryarn clear
command.rm -rf node_modules yarn.lock package-lock.json
and re-installing packages.Description
In the semver, unstable versions v3.7.0-* is treated as older than v3.7.0.
We must bump the patch version before adding a Canary verssion suffix. e.g. v3.7.1-canary-6264.
Reproducible demo
https://codesandbox.io/p/devbox/angry-antonelli-w9v59m?workspaceId=ws_5geAx947TkSAXN4qahDJMt
Steps to reproduce
Create a project
Upgrade Docusaurus to a Canary version by e.g. the following command:
Then run
yarn dev
Expected behavior
No upgrade recommendation banner
Actual behavior
Your environment
Self-service
The text was updated successfully, but these errors were encountered: