Skip to content

feat: improve UX handling when multiple main files detected #1700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: improve UX handling when multiple main files detected #1700

wants to merge 2 commits into from
+192 −2

Conversation

nilayarya
Copy link

@nilayarya nilayarya commented Apr 5, 2025 •
edited
Loading

Description of Change

Suggests UI changes to resolve #1508

  1. New MenuItem 'Set as Main Entry Point' available on right-click of valid main files (main.js, main.cjs, main.mjs)
  2. A Popup if there are multiple main files in the loaded fiddle (shows up only once a session )

Some gifs:

switchingsides


switcherooooo


showdialog

gist-url: https://gist.github.com/nilayarya/dfac02c9af5c699f3efc146ddf946f9f

CC @dsanders11

Checklist

  • PR description included and stakeholders cc'd
  • This PR was not created with AI. (PRs created mainly with AI will be closed. They waste our team's time. We ban repeat offenders.)
  • yarn test passes
  • tests are changed or added
  • PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

@nilayarya nilayarya requested review from codebytere and a team as code owners April 5, 2025 04:49
@coveralls
Copy link

Coverage Status

coverage: 87.482% (+0.01%) from 87.472%
when pulling 9c9e60d on nilayarya:multi-main
into d5e133f on electron:main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere Awaiting requested review from codebytere codebytere is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve UX Handling if Multiple Main Files
2 participants
@nilayarya @coveralls