support reconnections/retries for login-key commands

Author: ekaterina-nbl

Diff for: lib/util/ImpCentralApiHelper.js

@@ -37,8 +37,6 @@ const EntityStorage = require('./EntityStorage');
 const ACCESS_TOKEN_RENEW_BEFORE_EXPIRY_MS = 3 * 60 * 1000; // 3 min
 const LIST_PAGE_SIZE = 100;
 const CONCURRENT_REQUESTS_LIMIT = 5;
-// maximum number of attemts to refresh access token and restart an original request in case of authentication error
-const REFRESH_TOKEN_ATTEMPTS_LIMIT = 5;
 
 // Helper class for imp-central-api library requests.
 class ImpCentralApiHelper {
@@ -495,24 +493,24 @@ class ImpCentralApiHelper {
         return result;
     }
 
-    _processImpCentralApiReq(refreshAccessTokenOnAuthError, refreshTokenAttempts, entityType, id, impCentralApiMethod, ...args) {
+    _processImpCentralApiRequest(refreshAccessTokenOnAuthError, entityType, id, impCentralApiMethod, ...args) {
         UserInteractor.spinnerStart();
         return impCentralApiMethod(...args).
             then(result => this._resolveImpCentralApiResponse(result)).
             catch(error => {
                 if (this._isAuthenticationError(error)) {
-                    if (refreshAccessTokenOnAuthError && refreshTokenAttempts < REFRESH_TOKEN_ATTEMPTS_LIMIT) {
+                    if (refreshAccessTokenOnAuthError) {
                         // try to refresh access token in case of authentication error and then restart the original request
                         return this._refreshAccessToken().
-                            then(() => this._processImpCentralApiReq(
-                                refreshAccessTokenOnAuthError, ++refreshTokenAttempts, entityType, id, impCentralApiMethod, ...args));
+                            then(() => this._processImpCentralApiRequest(
+                                false, entityType, id, impCentralApiMethod, ...args));
                     }
                 }
                 else if (this._isRateLimitError(error)) {
                     return new Promise((resolve, reject) => {
                         setTimeout(() => resolve(), 1000)
-                    }).then(() => this._processImpCentralApiReq(
-                        refreshAccessTokenOnAuthError, refreshTokenAttempts, entityType, id, impCentralApiMethod, ...args));
+                    }).then(() => this._processImpCentralApiRequest(
+                        refreshAccessTokenOnAuthError, entityType, id, impCentralApiMethod, ...args));
                 }
                 else if (this._isEntityNotFoundError(error) && entityType && id) {
                     throw new Errors.EntityNotFoundError(entityType, id);
@@ -521,10 +519,6 @@ class ImpCentralApiHelper {
             });
     }
 
-    _processImpCentralApiRequest(refreshAccessTokenOnAuthError, entityType, id, impCentralApiMethod, ...args) {
-        return this._processImpCentralApiReq(refreshAccessTokenOnAuthError, 0, entityType, id, impCentralApiMethod, ...args);
-    }
-
     _isEntityNotFoundError(error) {
         return error instanceof ImpCentralApi.Errors.ImpCentralApiError &&
             error._statusCode === 404;