Use common upload artifacts directory to avoid scanning entire artifacts folder

Author: dibarbet

azure-pipelines-official.yml

@@ -144,52 +144,55 @@ extends:
       - job: OfficialBuild
         displayName: Official Build
         timeoutInMinutes: 360
+        variables:
+          - name: UploadArtifactsDirectory
+            value: $(Build.SourcesDirectory)\artifacts\UploadArtifacts
         templateContext:
-          outputParentDirectory: $(Build.SourcesDirectory)\artifacts
+          outputParentDirectory: $(UploadArtifactsDirectory)
           outputs:
 
           # Publish OptProf generated JSON files as a pipeline artifact. This allows for easy inspection from
           # a build execution.
           - output: pipelineArtifact
             displayName: 'Publish OptProf Data Files'
             condition: succeeded()
-            targetPath: '$(Build.SourcesDirectory)\artifacts\OptProf\$(BuildConfiguration)\Data'
+            targetPath: '$(UploadArtifactsDirectory)\OptProf\$(BuildConfiguration)\Data'
             artifactName: 'OptProf Data Files'
 
           - output: pipelineArtifact
             displayName: 'Publish Logs'
             condition: succeededOrFailed()
-            targetPath: '$(Build.SourcesDirectory)\artifacts\log\$(BuildConfiguration)'
+            targetPath: '$(UploadArtifactsDirectory)\log\$(BuildConfiguration)'
             artifactName: 'Build Diagnostic Files'
             publishLocation: Container
 
           - output: pipelineArtifact
             displayName: 'Publish Ngen Logs'
             condition: and(succeeded(), ${{ not(parameters.SkipApplyOptimizationData) }})
-            targetPath: '$(Build.SourcesDirectory)\artifacts\log\$(BuildConfiguration)\ngen'
+            targetPath: '$(UploadArtifactsDirectory)\log\$(BuildConfiguration)\ngen'
             artifactName: 'NGen Logs'
             publishLocation: Container
 
           # Publish an artifact that the RoslynInsertionTool is able to find by its name.
           - output: pipelineArtifact
             displayName: 'Publish Artifact VSSetup'
             condition: succeeded()
-            targetPath: '$(Build.SourcesDirectory)\artifacts\VSSetup\$(BuildConfiguration)'
+            targetPath: '$(UploadArtifactsDirectory)\VSSetup\$(BuildConfiguration)'
             artifactName: 'VSSetup'
 
           # Publish our NuPkgs as an artifact. The name of this artifact must be PackageArtifacts as the
           # arcade templates depend on the name.
           - output: pipelineArtifact
             displayName: 'Publish Artifact Packages'
             condition: succeeded()
-            targetPath: '$(Build.SourcesDirectory)\artifacts\packages\$(BuildConfiguration)'
+            targetPath: '$(UploadArtifactsDirectory)\packages\$(BuildConfiguration)'
             ArtifactName: 'PackageArtifacts'
 
           # Publish Asset Manifests for Build Asset Registry job
           - output: pipelineArtifact
             displayName: 'Publish Asset Manifests'
             condition: succeeded()
-            targetPath: '$(Build.SourcesDirectory)\artifacts\log\$(BuildConfiguration)\AssetManifest'
+            targetPath: '$(UploadArtifactsDirectory)\log\$(BuildConfiguration)\AssetManifest'
             ArtifactName: AssetManifests
 
           # Publish OptProf configuration files to the artifact service
@@ -199,7 +202,7 @@ extends:
             condition: succeeded()
             dropServiceURI: 'https://devdiv.artifacts.visualstudio.com'
             buildNumber: 'ProfilingInputs/$(System.TeamProject)/$(Build.Repository.Name)/$(SourceBranchName)/$(Build.BuildNumber)'
-            sourcePath: '$(Build.SourcesDirectory)\artifacts\OptProf\$(BuildConfiguration)\Data'
+            sourcePath: '$(UploadArtifactsDirectory)\OptProf\$(BuildConfiguration)\Data'
             toLowerCase: false
             usePat: false
             retentionDays: 90
@@ -208,8 +211,8 @@ extends:
           - output: nuget
             displayName: 'Publish CoreXT Packages'
             condition: succeeded()
-            packageParentPath: '$(Build.SourcesDirectory)\artifacts\VSSetup\$(BuildConfiguration)\DevDivPackages'
-            packagesToPush: '$(Build.SourcesDirectory)\artifacts\VSSetup\$(BuildConfiguration)\DevDivPackages\**\*.nupkg'
+            packageParentPath: '$(UploadArtifactsDirectory)\VSSetup\$(BuildConfiguration)\DevDivPackages'
+            packagesToPush: '$(UploadArtifactsDirectory)\VSSetup\$(BuildConfiguration)\DevDivPackages\**\*.nupkg'
             allowPackageConflicts: true
             nuGetFeedType: external
             publishFeedCredentials: 'DevDiv - VS package feed'
@@ -219,7 +222,7 @@ extends:
           - output: microBuildVstsDrop
             displayName: Upload VSTS Drop
             condition: succeeded()
-            dropFolder: 'artifacts\VSSetup\$(BuildConfiguration)\Insertion'
+            dropFolder: '$(UploadArtifactsDirectory)\VSSetup\$(BuildConfiguration)\Insertion'
             dropName: $(VisualStudio.DropName)
             accessToken: $(_DevDivDropAccessToken)
             dropRetentionDays: 90
@@ -349,6 +352,29 @@ extends:
             testRunTitle: 'Unit Tests'
           condition: and(succeededOrFailed(), ne(variables['SkipTests'], 'true'))
 
+        # Copy all the artifacts we're going to upload from this build to a common directory.
+        # This lets guardian scan all the upload artifacts in one go, while also avoiding
+        # scanning all the other random build artifacts.
+        - powershell: |
+            $commonArtifactsDir = "$(UploadArtifactsDirectory)"
+            New-Item -ItemType Directory -Force -Path $commonArtifactsDir
+
+            $artifactsToCopy = @(
+                "$(Build.SourcesDirectory)\artifacts\OptProf\",
+                "$(Build.SourcesDirectory)\artifacts\log\",
+                "$(Build.SourcesDirectory)\artifacts\VSSetup\",
+                "$(Build.SourcesDirectory)\artifacts\packages\"
+            )
+
+            foreach ($artifact in $artifactsToCopy) {
+                if (Test-Path $artifact) {
+                    Copy-Item -Path $artifact -Destination $commonArtifactsDir -Recurse -Force
+                } else {
+                    Write-Host "Artifact path not found- $artifact"
+                }
+            }
+          displayName: Copy Artifacts to Common Directory
+
       # Publish to Build Asset Registry
       - template: /eng/common/templates-official/job/publish-build-assets.yml@self
         parameters: