Skip to content

Commit 69acaba

Browse files
committed
Change the test to polling instead of just a single sleep
- Avoid flakyness due to time it takes to bind a service Signed-off-by: João Pereira <joaod@vmware.com>
1 parent 835b2ca commit 69acaba

File tree

1 file changed

+10
-11
lines changed

1 file changed

+10
-11
lines changed

integration/v7/isolated/service_command_test.go

+10-11
Original file line numberDiff line numberDiff line change
@@ -171,17 +171,16 @@ var _ = Describe("service command", func() {
171171
})
172172

173173
It("displays the bound apps", func() {
174-
//Delay to reduce flakiness
175-
time.Sleep(10 * time.Second)
176-
session := helpers.CF(serviceCommand, serviceInstanceName, "-v")
177-
Eventually(session).Should(Exit(0))
178-
179-
Expect(session).To(SatisfyAll(
180-
Say(`Showing bound apps:\n`),
181-
Say(`name\s+binding name\s+status\s+message\n`),
182-
Say(`%s\s+%s\s+create succeeded\s*\n`, appName1, bindingName1),
183-
Say(`%s\s+%s\s+create succeeded\s*\n`, appName2, bindingName2),
184-
))
174+
Eventually(func(g Gomega) {
175+
session := helpers.CF(serviceCommand, serviceInstanceName, "-v").Wait()
176+
g.Expect(session).Should(Exit(0))
177+
g.Expect(session).Should(SatisfyAll(
178+
Say(`Showing bound apps:\n`),
179+
Say(`name\s+binding name\s+status\s+message\n`),
180+
ContainSubstring(`%s\s+%s\s+create succeeded\s*\n`, appName1, bindingName1),
181+
ContainSubstring(`%s\s+%s\s+create succeeded\s*\n`, appName2, bindingName2),
182+
))
183+
}).Should(Succeed())
185184
})
186185
})
187186

0 commit comments

Comments
 (0)