Add tests

Author: kamil-certat

intelmq/lib/upgrades.py

@@ -994,6 +994,9 @@ def v341_new_fields(configuration, harmonization, dry_run, **kwargs):
         "product.vulnerabilities",
     ]:
         if field not in harmonization["event"]:
+            if field not in builtin_harmonisation["event"]:
+                # ensure forward-compatibility if we ever remove something from harmonisation
+                continue
             harmonization["event"][field] = builtin_harmonisation["event"][field]
             changed = True
     return changed, configuration, harmonization

intelmq/tests/lib/test_upgrades.py

@@ -856,6 +856,17 @@ def test_v340_twitter_collector(self):
         self.assertIn('twitter-collector', result[0])
         self.assertEqual(V340_TWITTER_COLLECTOR_IN, result[1])
 
+    def test_v341_new_fields(self):
+        """ Test adding new harmonisation fields """
+        result = upgrades.v341_new_fields({}, {"event": {"old-field": "must stay"}}, False)
+        self.assertTrue(result[0])
+        self.assertIn("old-field", result[2]["event"])
+        self.assertIn("product.full_name", result[2]["event"])
+        self.assertIn("product.name", result[2]["event"])
+        self.assertIn("product.vendor", result[2]["event"])
+        self.assertIn("product.version", result[2]["event"])
+        self.assertIn("product.vulnerabilities", result[2]["event"])
+
 
 for name in upgrades.__all__:
     setattr(TestUpgradeLib, 'test_function_%s' % name,