Skip to content

Hide Profiles.php Unless BU Profiles Plugin is Activated #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
acketon opened this issue Jun 14, 2021 · 2 comments · May be fixed by #277
Closed

Hide Profiles.php Unless BU Profiles Plugin is Activated #266

acketon opened this issue Jun 14, 2021 · 2 comments · May be fixed by #277
Assignees
Labels
On Dev List 🔥 Product bug A bug which is not directly related to a custom child theme.

Comments

@acketon
Copy link
Member

acketon commented Jun 14, 2021

Profiles.php page template shows up in the dropdown of page templates even when the BU Profiles plugin is disabled. It doesn't make sense to show it if the plugin is not enabled. Related to #35.

@ashleykolodziej ashleykolodziej added 🔥 Product bug A bug which is not directly related to a custom child theme. On Dev List labels Jul 30, 2021
@aremery
Copy link
Collaborator

aremery commented Sep 17, 2021

It's easy enough to unregister the template if the plugin is not activated. Here's a pull request. We can merge it and be done with it but is this really how we want to handle this? Why is the infrastructure designed in a way that the template for the plugin is not in the plugin? Is there a good reason? Should we be propagating this design pattern?

@aremery aremery self-assigned this Sep 17, 2021
@aremery
Copy link
Collaborator

aremery commented Sep 21, 2021

@acketon do you want the above pr merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On Dev List 🔥 Product bug A bug which is not directly related to a custom child theme.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants