From 9b2539a80b7327d11daf3e5bedf0bdabe9b691cb Mon Sep 17 00:00:00 2001
From: adamhaeger <adamgullerud@gmail.com>
Date: Fri, 29 Nov 2024 14:11:35 +0100
Subject: [PATCH 1/3] Explicitly passing props

---
 src/app-components/Input/Input.tsx                     | 10 ++++++++--
 src/layout/InstantiationButton/InstantiationButton.tsx |  1 -
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/src/app-components/Input/Input.tsx b/src/app-components/Input/Input.tsx
index b459a21e55..74d114931a 100644
--- a/src/app-components/Input/Input.tsx
+++ b/src/app-components/Input/Input.tsx
@@ -34,7 +34,7 @@ export type InputProps = {
 >;
 
 export function Input(props: InputProps) {
-  const { size = 'sm', ...rest } = props;
+  const { size = 'sm', prefix, suffix, characterLimit, error, id, readOnly, type } = props;
 
   if (props.textonly) {
     const { value, id, className } = props;
@@ -57,7 +57,13 @@ export function Input(props: InputProps) {
   return (
     <Textfield
       size={size}
-      {...rest}
+      prefix={prefix}
+      suffix={suffix}
+      type={type}
+      characterLimit={characterLimit}
+      error={error}
+      id={id}
+      readOnly={readOnly}
     />
   );
 }
diff --git a/src/layout/InstantiationButton/InstantiationButton.tsx b/src/layout/InstantiationButton/InstantiationButton.tsx
index 1d54f38b40..ad4efd40e5 100644
--- a/src/layout/InstantiationButton/InstantiationButton.tsx
+++ b/src/layout/InstantiationButton/InstantiationButton.tsx
@@ -32,7 +32,6 @@ export const InstantiationButton = ({ children, ...props }: Props) => {
 
   return (
     <Button
-      {...props}
       id={props.node.id}
       onClick={onClick}
       isLoading={isLoading}

From 8acf5d3ca64d89729445cb5bf75c36deebbe3d9f Mon Sep 17 00:00:00 2001
From: Adam Haeger <adamgullerud@gmail.com>
Date: Mon, 9 Dec 2024 08:28:08 +0100
Subject: [PATCH 2/3] fixed props

---
 src/app-components/Input/Input.tsx | 39 +++++++++++++++++++++++++++---
 1 file changed, 36 insertions(+), 3 deletions(-)

diff --git a/src/app-components/Input/Input.tsx b/src/app-components/Input/Input.tsx
index 74d114931a..7468025459 100644
--- a/src/app-components/Input/Input.tsx
+++ b/src/app-components/Input/Input.tsx
@@ -34,10 +34,31 @@ export type InputProps = {
 >;
 
 export function Input(props: InputProps) {
-  const { size = 'sm', prefix, suffix, characterLimit, error, id, readOnly, type } = props;
+  const {
+    size = 'sm',
+    prefix,
+    suffix,
+    characterLimit,
+    error,
+    disabled,
+    id,
+    readOnly,
+    type,
+    value,
+    className,
+    'aria-label': ariaLabel,
+    'aria-describedby': ariaDescribedby,
+    onChange,
+    onBlur,
+    autoComplete,
+    required,
+    placeholder,
+    inputMode,
+    style,
+    textonly,
+  } = props;
 
-  if (props.textonly) {
-    const { value, id, className } = props;
+  if (textonly) {
     if (value === null || (typeof value === 'string' && value.length === 0)) {
       return null;
     }
@@ -64,6 +85,18 @@ export function Input(props: InputProps) {
       error={error}
       id={id}
       readOnly={readOnly}
+      disabled={disabled}
+      value={value}
+      className={className}
+      aria-label={ariaLabel}
+      aria-describedby={ariaDescribedby}
+      onChange={onChange}
+      onBlur={onBlur}
+      autoComplete={autoComplete}
+      required={required}
+      placeholder={placeholder}
+      inputMode={inputMode}
+      style={style}
     />
   );
 }

From 73bdda6b0479cf15d6165f0b7fbc547e86ea3a59 Mon Sep 17 00:00:00 2001
From: adamhaeger <adamgullerud@gmail.com>
Date: Thu, 12 Dec 2024 13:25:11 +0100
Subject: [PATCH 3/3] update

---
 src/app-components/Input/Input.tsx | 54 +++++++++++++-----------------
 1 file changed, 24 insertions(+), 30 deletions(-)

diff --git a/src/app-components/Input/Input.tsx b/src/app-components/Input/Input.tsx
index 4db6b18fe6..7468025459 100644
--- a/src/app-components/Input/Input.tsx
+++ b/src/app-components/Input/Input.tsx
@@ -44,26 +44,21 @@ export function Input(props: InputProps) {
     id,
     readOnly,
     type,
-    textonly,
     value,
     className,
+    'aria-label': ariaLabel,
+    'aria-describedby': ariaDescribedby,
     onChange,
+    onBlur,
     autoComplete,
     required,
-    onBlur,
     placeholder,
     inputMode,
     style,
+    textonly,
   } = props;
 
-  const onPaste = (event: React.ClipboardEvent<HTMLInputElement>) => {
-    if (readOnly) {
-      event.preventDefault();
-    }
-  };
-
   if (textonly) {
-    const { value, id, className } = props;
     if (value === null || (typeof value === 'string' && value.length === 0)) {
       return null;
     }
@@ -82,27 +77,26 @@ export function Input(props: InputProps) {
 
   return (
     <Textfield
-      {...{
-        onPaste,
-        size,
-        prefix,
-        suffix,
-        characterLimit,
-        error,
-        disabled,
-        id,
-        readOnly,
-        type,
-        value,
-        className,
-        onChange,
-        autoComplete,
-        required,
-        onBlur,
-        placeholder,
-        inputMode,
-        style,
-      }}
+      size={size}
+      prefix={prefix}
+      suffix={suffix}
+      type={type}
+      characterLimit={characterLimit}
+      error={error}
+      id={id}
+      readOnly={readOnly}
+      disabled={disabled}
+      value={value}
+      className={className}
+      aria-label={ariaLabel}
+      aria-describedby={ariaDescribedby}
+      onChange={onChange}
+      onBlur={onBlur}
+      autoComplete={autoComplete}
+      required={required}
+      placeholder={placeholder}
+      inputMode={inputMode}
+      style={style}
     />
   );
 }